Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some keyboard shortcuts not working (macOS) #266

Open
sganslandt opened this issue Nov 27, 2023 · 6 comments
Open

some keyboard shortcuts not working (macOS) #266

sganslandt opened this issue Nov 27, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@sganslandt
Copy link

Some keyboard shortcuts, particularly cmd+Z (crucial) and cmd+A, does not work inside the diagrams editor even though they don't have any other function in IntelliJ or the OS. In the IntelliJ keymap they are mapped to the standard functions, undo and select all.

@rdmueller
Copy link
Member

hm. This seems to be the place to start debugging:

if (eventName === "keydown") {

But no clue why this happens.

@lixinbao-100
Copy link

You can try version 0.2.3, there are no bugs that cannot be undone

@feliksik
Copy link

Confirmed in 0.2.5 with IntelliJ 2023.3.5 Ultimate Build #IU-233.14808.21.

It seems that when editing the text in a box, cmd-Z does work.

However, after dragging a shape to another position, it does not work.

@ahus1 ahus1 added the help wanted Extra attention is needed label May 26, 2024
@ahus1
Copy link
Collaborator

ahus1 commented May 26, 2024

Due to time constraints with the current maintainers, I'm marking this a "help wanted" - maybe someone else has the time to look at this one.

@dannybloe
Copy link

I think none of the cmd keys work on MacOS. That makes this plugin basically inoperable for now. Hopefully someone can pick this up.

@rdmueller
Copy link
Member

"inoperable" is a hard word. I use the plugin quite often.
I do agree that Functionality is missing.

It seems that keyboard shortcuts are handled here: https://github.com/docToolchain/diagrams.net-intellij-plugin/blob/main/src/webview/index.html#L320 (ah, already mentioned above).

So, we need someone who has the chance to invest some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants