-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Ability to provide wildcard for devices in --device option #2968
Comments
Would the |
It would not work because we need all the devices to be there in the container at the start so that the app that is started as has access to all the devices. |
@thaJeztah - To accomplish the desired functionality today, we have to use an environment variable (VISIBLE_DEVICES=ALL) and an OCI hook to ensure "all" devices get mounted in the container. If docker supported a wildcard, we'd no longer have a reason to keep producing our oci-hook. A big win for ourselves and customers, but potentially a win for all teams using multiple devices in containers, e.g. GPU consumers. |
@thaJeztah - Have created a draft pull request. Please do let us know if we should make this change in the client side as was done in the PR or if we should move the functionality to the server side. |
I was going to open a similar feature request, would love to see this pull request accepted ! |
This needs to be implemented on the daemon-side, as docker uses a client-server architecture, so the CLI may not be running on the same host as the daemon is running (let me leave the comment on the PR as well) |
This takes care of the [issue](docker/cli#2968) from the server side Signed-off-by: Venky Natham <[email protected]>
Thanks. Have updated the change in the cli side and also created a PR in the engine side. |
Any news on this? |
Description
If we have devices /dev/xyz1 to /dev/xyz10, currently to bind mount all these devices we have to use --device=/dev/xyz1 --device=/dev/xyz2 ...... It would be good to have a wildcard like --device=/dev/xyz* that lets all the devices show up in the container.
The text was updated successfully, but these errors were encountered: