From bea454eefc4bd341e1550b0befd6052db2d175fe Mon Sep 17 00:00:00 2001
From: Benjamin Eberlei <kontakt@beberlei.de>
Date: Thu, 10 Oct 2024 13:54:34 +0200
Subject: [PATCH] [GH-8471] undeprecate partials completly (#11647)

* [GH-8471] Undeprecate all PARTIAL object usage.
---
 UPGRADE.md           | 12 +++++++++---
 src/Query/Parser.php |  8 --------
 src/UnitOfWork.php   | 10 ----------
 3 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/UPGRADE.md b/UPGRADE.md
index a42be6a437..a44bbd5a35 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -8,10 +8,16 @@ change in behavior.
 
 Progress on this is tracked at https://github.com/doctrine/orm/issues/11624 .
 
-## PARTIAL DQL syntax is undeprecated for non-object hydration
+## PARTIAL DQL syntax is undeprecated 
 
-Use of the PARTIAL keyword is not deprecated anymore in DQL when used with a hydrator
-that is not creating entities, such as the ArrayHydrator.
+Use of the PARTIAL keyword is not deprecated anymore in DQL, because we will be
+able to support PARTIAL objects with PHP 8.4 Lazy Objects and
+Symfony/VarExporter in a better way. When we decided to remove this feature
+these two abstractions did not exist yet.
+
+WARNING: If you want to upgrade to 3.x and still use PARTIAL keyword in DQL
+with array or object hydrators, then you have to directly migrate to ORM 3.3.x or higher.
+PARTIAL keyword in DQL is not available in 3.0, 3.1 and 3.2 of ORM.
 
 ## Deprecate `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()`
 
diff --git a/src/Query/Parser.php b/src/Query/Parser.php
index 2a95297efd..388cfcc8e4 100644
--- a/src/Query/Parser.php
+++ b/src/Query/Parser.php
@@ -1850,14 +1850,6 @@ public function JoinAssociationDeclaration()
      */
     public function PartialObjectExpression()
     {
-        if ($this->query->getHydrationMode() === Query::HYDRATE_OBJECT) {
-            Deprecation::trigger(
-                'doctrine/orm',
-                'https://github.com/doctrine/orm/issues/8471',
-                'PARTIAL syntax in DQL is deprecated for object hydration.'
-            );
-        }
-
         $this->match(TokenType::T_PARTIAL);
 
         $partialFieldSet = [];
diff --git a/src/UnitOfWork.php b/src/UnitOfWork.php
index 46c2893dcc..2969a3e0e0 100644
--- a/src/UnitOfWork.php
+++ b/src/UnitOfWork.php
@@ -41,7 +41,6 @@
 use Doctrine\ORM\Persisters\Entity\JoinedSubclassPersister;
 use Doctrine\ORM\Persisters\Entity\SingleTablePersister;
 use Doctrine\ORM\Proxy\InternalProxy;
-use Doctrine\ORM\Query\SqlWalker;
 use Doctrine\ORM\Utility\IdentifierFlattener;
 use Doctrine\Persistence\Mapping\RuntimeReflectionService;
 use Doctrine\Persistence\NotifyPropertyChanged;
@@ -2920,15 +2919,6 @@ private function newInstance(ClassMetadata $class)
      */
     public function createEntity($className, array $data, &$hints = [])
     {
-        if (isset($hints[SqlWalker::HINT_PARTIAL])) {
-            Deprecation::trigger(
-                'doctrine/orm',
-                'https://github.com/doctrine/orm/issues/8471',
-                'Partial Objects are deprecated for object hydration (here entity %s)',
-                $className
-            );
-        }
-
         $class = $this->em->getClassMetadata($className);
 
         $id     = $this->identifierFlattener->flattenIdentifier($class, $data);