Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode bug in envelope_api.get_document #87

Open
matthewcocook opened this issue Aug 26, 2020 · 1 comment
Open

unicode bug in envelope_api.get_document #87

matthewcocook opened this issue Aug 26, 2020 · 1 comment

Comments

@matthewcocook
Copy link

matthewcocook commented Aug 26, 2020

v. 3.4.0

Problem file name had Unicode character in it: Minutes of: Arise & Shine🌤.pdf

our code looks something like this and works for non unicode named documents.

temp_file = self.envelope_api.get_document(
            account_id=self.account_id,
            document_id=(int),
            envelope_id=(int)
        )

/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:574 
in __deserialize_file/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:256 
in deserialize/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:186 
in __call_api/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:354 
in call_api/usr/local/lib/python3.6/dist-packages/docusign_esign/apis/envelopes_api.py:5274 
in get_document_with_http_info/usr/local/lib/python3.6/dist-packages/docusign_esign/apis/envelopes_api.py:5157 
in get_document/PROJECT_ROOT/cloud/integrations/signature.py:302 in download_file

--

@LarryKlugerDS
Copy link
Contributor

Hi @matthewcocook,

It looks like this section of code has the bug, specifically the code is not stripping out non-ascii characters. (And it should also remove any characters that would be problematic within file names such as / or \ ...)
I have filed bug report DCM-4581

In addition, in the future, the SDK will not store downloaded documents in temp. See docusign/docusign-esign-php-client#56

I don't have a date from our engineering group on when this bug will be fixed. A workaround is to call the API directly.

Thank you for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants