Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing for gRPC #1570

Open
broody opened this issue Feb 20, 2024 · 15 comments
Open

Better testing for gRPC #1570

broody opened this issue Feb 20, 2024 · 15 comments
Labels
help wanted Extra attention is needed torii

Comments

@broody
Copy link
Collaborator

broody commented Feb 20, 2024

Currently, there isn't very good coverage for gRPC. Would be great to have tests that covers all queries and subscriptions.

@gianalarcon
Copy link
Contributor

gianalarcon commented Feb 20, 2024

I would like to work on this as well =)

@glihm glihm removed the ODHack OnlyDust Hack fest label Jun 19, 2024
@glihm
Copy link
Collaborator

glihm commented Jun 19, 2024

@gianalarcon how are you doing? Is this something you still want to tackle? We've to setup a whole test suite for gRPC automated testing. @lambda-0x should take over on some part of Torii, but if you've already started something let's sync on that! 👍

@glihm glihm changed the title [Torii] Better testing for gRPC Better testing for gRPC Jun 19, 2024
@glihm glihm added the torii label Jun 19, 2024
@gianalarcon
Copy link
Contributor

All yours @glihm @lambda-0x . I would like to contribute in upcoming issues related to torii(graphql, grpc).

@gianalarcon gianalarcon removed their assignment Jun 20, 2024
@PedroRosalba
Copy link

@broody Can I work on this?

@broody
Copy link
Collaborator Author

broody commented Jun 26, 2024

@broody Can I work on this?

Ah I've been out of the loop, I think @lambda-0x is taking over this, but deferring to @glihm sensei

@Supa-mega
Copy link

hello @broody can i also hop on this

@Kelvin01
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I've work with grpc a couple of times in the past. For UT usually what I do is creating a local grpc for listening the requests and I'd return some mocked data in order to increase coverage and make the code falls to the scenarios I want to test.

@CollinsC1O
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a frontend and a blockchain developer. I will love to work on this

@llamitaOnfire
Copy link

llamitaOnfire commented Sep 12, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I’m a Computer Engineering student and a web developer with a growing interest in blockchain. I’ve recently started contributing to open source and am passionate about projects that encourage innovation and collaboration. My background in Computer Engineering and my focus on learning new technologies, including gRPC, aligns well with this issue. While I’m relatively new to open source, I’m eager to apply my skills, gain practical experience with gRPC, and contribute meaningfully to this project

How I plan on tackling this issue

Plan for Tackling the Issue:

Familiarize myself with the existing codebase and testing framework: I will review the current implementation of gRPC queries and subscriptions to understand the current test coverage and where gaps exist.
Identify all gRPC queries and subscriptions: I’ll document all the queries and subscriptions that need coverage, ensuring that none are missed.
Write comprehensive tests: Using this list, I will write unit tests and integration tests to ensure that all gRPC queries and subscriptions are properly tested.
Ensure scalability: I will focus on writing tests that not only validate functionality but also handle edge cases and scalability concerns.
Submit a PR for review: Once the tests are written, I will submit a pull request for feedback and refinement.
Looking forward to contributing and helping improve the test coverage for gRPC!

@jcampos2907
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have good knowledge using RPC from back end developing

@GradleD
Copy link

GradleD commented Nov 9, 2024

I’m interested in this one.

@Richiejosh
Copy link

I’d love to work on this task.

@teskpicoin
Copy link

I'd like to take this issue.

@Samibhr09
Copy link

May I take care of this?

@glihm glihm removed the good first issue Good for newcomers label Dec 2, 2024
@glihm
Copy link
Collaborator

glihm commented Dec 2, 2024

Sorry for the delay on this one guys.
Removing the good first issue from now since there are some internal changes on-going.
Will update here in the future based on the rework. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed torii
Projects
No open projects
Status: No status
Development

No branches or pull requests