Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torii] Add version and commit hash in a version table #2837

Open
edisontim opened this issue Dec 21, 2024 · 2 comments
Open

[torii] Add version and commit hash in a version table #2837

edisontim opened this issue Dec 21, 2024 · 2 comments
Labels

Comments

@edisontim
Copy link
Collaborator

edisontim commented Dec 21, 2024

Would be amazing to have some information around what version the torii is running, for example we had some instances on Eternum where we weren't sure anymore of what version was running on a remote torii (or commit hash, as we were running some versions from different branches often as well).
It wasn't possible to get the specific version unless with slot command, or having to ask the maintainer of the instance.
My proposed solution is to store the version and commit hash of the torii binary as start. It would be stored inside a version table in the database to be able to run an SQL query and retrieve that version

@edisontim edisontim changed the title [torii] Had version and commit hash in the metadata table [torii] Add version and commit hash in the metadata table Jan 10, 2025
@glihm
Copy link
Collaborator

glihm commented Jan 16, 2025

Would you mind editing the description @edisontim to be sure the wanted solution is clear? :)

@glihm glihm added the torii label Jan 16, 2025
@edisontim edisontim changed the title [torii] Add version and commit hash in the metadata table [torii] Add version and commit hash in a version table Jan 21, 2025
@edisontim
Copy link
Collaborator Author

Would you mind editing the description @edisontim to be sure the wanted solution is clear? :)

Sorry created the issue during the s0 rush, so I didn't make it really clear. Added a bit of context to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants