Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme installed could be optional #577

Closed
LuSouth opened this issue Oct 20, 2022 · 2 comments
Closed

Theme installed could be optional #577

LuSouth opened this issue Oct 20, 2022 · 2 comments

Comments

@LuSouth
Copy link

LuSouth commented Oct 20, 2022

Is your feature request related to a problem? Please describe.
In fact, I think The Doki Theme now have too many themes. But jetbrain will give a preview if you move you pointer to the theme when you are choosing, it cause freezing.
image

Describe the solution you'd like
I hope not all the theme were installed at the beginning. User could download theme for github or other way, The Doki Theme just be a starter.

by the way, it is hard for me to know Japanese Name from Romanji. I don't know whether jetbrain support japanese or not. I think most of this plugin user could read a little Japanese?

@Unthrottled
Copy link
Member

Unthrottled commented Oct 20, 2022

In fact, I think The Doki Theme now have too many themes

I don't think this is the fact. Themes aren't applied until user selects theme. So I doubt that the presence of many themes causes this issue.

What I do think might be causing the issue, is the fact that if you have the wallpaper setting enabled & you are trying to do the quick preview, that might cause the performance issue. Loading the single wallpaper for the theme to be painted is a memory intensive process. Which may be causing the slow down.

I'd suggest you not preview each theme with the wallpaper enabled. Instead try it without the wallpaper setting enabled.

I also think the performance varies from machine to machine as well.

Kapture.2022-10-20.at.05.20.20.mp4

My Setup

IntelliJ IDEA 2022.2.2 (Ultimate Edition)
Build #IU-222.4167.29, built on September 13, 2022
Runtime version: 17.0.4+7-b469.53 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.6
GC: G1 Young Generation, G1 Old Generation
Memory: 10280M
Cores: 10
Metal Rendering is ON
Registry:
    debugger.click.disable.breakpoints=true
    ide.intellij.laf.enable.animation=true
    ide.balloon.shadow.size=0

Non-Bundled Plugins:
    io.unthrottled.theme.randomizer (0.7.1)
    com.intellij.properties.bundle.editor (222.4167.21)
    org.jetbrains.kotlin (222-1.7.20-release-201-IJ4167.29)
    com.fwdekker.randomness (2.7.5)
    io.acari.DDLCTheme (88.1-1.5.3)
    io.unthrottled.amii (1.1.2)
    String Manipulation (9.5.1)
    IdeaVIM (1.11.1)
    GrepConsole (12.15.211.6693.1)
    izhangzhihao.rainbow.brackets (6.26)

Kotlin: 222-1.7.20-release-201-IJ4167.29

it is hard for me to know Japanese Name from Romanji. I don't know whether jetbrain support japanese or not. I think most of this plugin user could read a little Japanese?

I don't think there is a way to localize the theme name itself. But it can be investigated a part of #533

I'm going to close this issue, but we can still discuss further if needed.

@Unthrottled Unthrottled closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
@LuSouth
Copy link
Author

LuSouth commented Oct 20, 2022

thanks
I try to disable wallpaper when preview and it is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants