-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-test compilation error pattern doesn't match Go 1.14 output #362
Comments
phst
added a commit
to phst/go-mode.el
that referenced
this issue
May 10, 2020
Fixes dominikh#361, dominikh#362 Restrict the prefix and filename pattern (Bug dominikh#361), and also allow for a test name prefix (Bug dominikh#362). Add regression tests for these bugs.
phst
added a commit
to phst/go-mode.el
that referenced
this issue
May 10, 2020
Fixes dominikh#361, dominikh#362 Restrict the prefix and filename pattern (Bug dominikh#361), and also allow for a test name prefix (Bug dominikh#362). Add regression tests for these bugs.
I cannot reproduce this with go1.18-8ff254e30b:
|
Maybe this got fixed again by a change in Go 1.15 (https://go.dev/doc/go1.15#testing):
It's probably still worth adding a unit test to ensure that Emacs correctly parses the test output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The output of
go test -v
has changed somewhat in Go 1.14. For example, with this/tmp/f/foo_test.go
:the Go 1.13 output is
but the Go 1.14 output is
Note that the error message now has the prefix
Test:
(i.e. test name, colon, space). This is probably related to the change described at https://golang.org/doc/go1.14#go-test. However, thego-test
pattern treats the entireTest: foo_test.go
part as filename.go-test
should be adapted accordingly.The text was updated successfully, but these errors were encountered: