Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Code cleanup and maintainability improvements #627

Open
ikergcalvino opened this issue Feb 19, 2025 · 2 comments
Open

[Proposal] Code cleanup and maintainability improvements #627

ikergcalvino opened this issue Feb 19, 2025 · 2 comments

Comments

@ikergcalvino
Copy link

Hi,

First of all, thank you for this amazing project! I recently started using it, and I really appreciate all the work that has gone into it.

As I go through the code, I’ve noticed some opportunities for small improvements that could enhance maintainability and readability, such as:

  • Cleaning up unused code (libraries, classes, attributes).
  • Updating and organizing imports.
  • Improving print statements/logging and comments for clarity.

I’d love to contribute by gradually making these kinds of refinements and opening PRs along the way. Since this is my first time contributing like this to a public repository, I want to make sure I’m doing things correctly and communicating my intentions clearly. Please let me know if there’s anything I should be aware of in terms of project guidelines or any specific direction you’d prefer for these improvements.

I completely understand that certain parts of the code might be the way they are for specific reasons, and I don’t want to make unnecessary changes. My goal is just to help improve the project in a way that makes sense. Let me know if you’re open to this kind of contribution!

Looking forward to your thoughts, and thanks again for this great project! 😊

@akhepcat
Copy link

Well, you can just do what I did, which is find something interesting, and submit a PR against it.

I'd probably stick with the 4.2-dev branch for now, for your cleanup auditing, just because that's where the fun is happening.

@DaanSelen
Copy link
Collaborator

DaanSelen commented Feb 20, 2025

Well, you can just do what I did, which is find something interesting, and submit a PR against it.

I'd probably stick with the 4.2-dev branch for now, for your cleanup auditing, just because that's where the fun is happening.

Exactly. Branch 4.2-dev is currently in development. The main branch will only receive patches such as language updates or bug- or security-fixes. Our eyes are on the next release.

I've also been wanting to rewrite the wgd.sh utility or at least try to improve it but so far...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants