-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detecting changes against main branch on main branch merge? #201
Comments
I'm having a similar problem. The action works perfectly fine in PRs/branches, but once I perform a merge operation... it fails because of the same problem. I'm considering doing something similar as to what you have done, although perhaps even more complicated, with some added conditional logic to only perform the checkout when there is a merge operation (what remains to be seen is how I'll make it to define Another option is to make this to not execute this action on merge, and modify the conditionals that depend on this one to also execute on merge. That would save less time in CI, but I don't expect as many merge operations as commits to PRs. EDIT: It seems that we can use conditionals in expressions actions/runner#409 , the approximation is a bit brittle ("same" as in POSIX shell, ugh), but better than nothing. |
* run tests * Try to stop the test failing in main Based on dorny/paths-filter#201
Hi both. Can't you achieve this with just |
I have the same problem and I'm curious to know if anyone has a solution before I start spending time on tests |
Same issue here where no changes exist when PR is merged into main. |
My use case involves a merge commit from a main branch PR to a different branch. I have successfully managed to get it working. I needed to download the full repo, get the previous commit and use it as a base.
|
Thanks! My solution was to avoid running the action all together on pushes to main (not needed for my use case to begin with) - and instead run it on pull requests only. |
I'm trying to detect changes on the main branch when merging a PR into the main branch. I kept on getting
I've solved it by
Surely I'm over complicating this, and there is a simpler way to do this?
The text was updated successfully, but these errors were encountered: