Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pull_request_review event. #232

Open
jcchavezs opened this issue Apr 5, 2024 · 0 comments
Open

Allow pull_request_review event. #232

jcchavezs opened this issue Apr 5, 2024 · 0 comments

Comments

@jcchavezs
Copy link

Hi, thanks for this action, it helps a lot to filter executions. Now I am facing an issue:

Currently when using this action on a pull_request_review event we get

This action can be triggered only by pull_request or push event

however, there are common cases where you only want the job to happen if it gets an approval however that event won't trigger the job because this action only support push and pull_request.

Imagine this workflow:

name: My workflow
on:
  pull_request_review:
    types: [submitted]
jobs:
  terraform-plan:
    runs-on: [layer0-runner]
    if: github.event.review.state == 'approved'
    steps:
    - uses: actions/checkout@v3
    - uses: dorny/paths-filter@v3
       id: changes
      with:
        filters: |
          src:
            - 'src/**'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant