Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship Field Search: Site Or Host Field #31280

Closed
nicobytes opened this issue Jan 31, 2025 · 2 comments · Fixed by #31298
Closed

Relationship Field Search: Site Or Host Field #31280

nicobytes opened this issue Jan 31, 2025 · 2 comments · Fixed by #31298
Assignees
@nicobytes
Labels
Sprint: Injected Team : Falcon Type : New Functionality

Comments

@nicobytes
Copy link
Contributor

Parent Issue

#31127

User Story

As a Content Author, I want to see a site or folder field to filter the relationships so that I can select a site or folder

Acceptance Criteria

  1. Create a content type with a relationship.
  2. Create content according to the previously created content.
  3. Open the filter popover.
  4. Use the site or folder field.
  5. A dropdown with all available sites should appear.

Note: This card does not include the filter functionality because the endpoint for filtering has not been developed yet.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@nicobytes nicobytes self-assigned this Jan 31, 2025
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Jan 31, 2025
@nicobytes nicobytes linked a pull request Feb 3, 2025 that will close this issue
chore(edit-content): add site field to search relationships #31298
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

PRs:

@nicobytes nicobytes mentioned this issue Feb 3, 2025
Merged
3 tasks
@nicobytes
Copy link
Contributor Author

nicobytes commented Feb 4, 2025 •
edited
Loading

  1. Create a content type with a relationship.
  2. Create content according to the previously created content.
  3. Open the filter popover.
  4. Use the site or folder field.
  5. A dropdown with all available sites should appear.
search.mp4

@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Feb 4, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
@nicobytes
chore(edit-content): add site field to search relationships (#31298)
6525f41 
### Parent Issue

#31280 

### Proposed Changes

This pull request introduces a new `SiteFieldComponent` for selecting a
site from a tree structure in the `dot-edit-content-relationship-field`
module. The changes include the implementation of the component, its
associated styles, unit tests, and a store for managing the component's
state.

Key changes:

### Component Implementation:
*
[`site-field.component.ts`](diffhunk://#diff-e4382792ef202b90112a6556f3c1d63c21e8f7c8f747f1cb09b77d25bfbccb1bR1-R129):
Added the `SiteFieldComponent` which implements `ControlValueAccessor`
to work with Angular forms and uses PrimeNG's `TreeSelect` component for
the UI.
*
[`site-field.component.html`](diffhunk://#diff-c61c7bf501226714ed8accbb0b61a025e57c0179affa0a1fc53159f1c05b76b2R1-R44):
Created the template for the `SiteFieldComponent` using `p-treeSelect`
for the tree structure and added error handling.
*
[`site-field.component.scss`](diffhunk://#diff-06646f7c6ecfc10412b89a98dd4935436d2e7d23feea988b0f4a557018d57b63R1-R7):
Added styles to ensure the `TreeSelect` component spans the full width
of its container.

### Unit Tests:
*
[`site-field.component.spec.ts`](diffhunk://#diff-520d6e974cad3c205627cc77b5a0ec56b334303f941a74a67554c2609dabdfddR1-R198):
Added comprehensive unit tests for the `SiteFieldComponent`, covering
initial state, control value accessor implementation, and edge cases.
*
[`site-field.store.spec.ts`](diffhunk://#diff-810b776b9ac7916a02ef0ab369f0584f5018a2a7d8750e18c0ea99e8ec344cf4R1-R253):
Added unit tests for the `SiteFieldStore`, ensuring proper loading of
sites, handling of errors, and state management.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicobytes nicobytes

Labels
Sprint: Injected Team : Falcon Type : New Functionality
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(edit-content): add site field to search relationships dotCMS/core
1 participant
@nicobytes