Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Response Signated Signed-ness can flip when xml is read #112

Open
Fusty opened this issue Oct 10, 2018 · 1 comment
Open

Response Signated Signed-ness can flip when xml is read #112

Fusty opened this issue Oct 10, 2018 · 1 comment

Comments

@Fusty
Copy link

Fusty commented Oct 10, 2018

The value of samlResponse.isSigned() before this line is true

https://github.com/dotCMS/plugin-com.dotcms.dotsaml/blob/4.0-4.3.x/src/com/dotcms/plugin/saml/v3/handler/HttpPostAssertionResolverHandlerImpl.java#L94

After this line it is false.

This may be because I am logging at the DEBUG level.

I just ran into this while setting up a Google G-Suite Apps SAML IdP.

The fix is to verify the response signature before assertion xml is converted to an object. I'm not certain why this occurs, but it is consistent in my current environment and this tiny tweak fixes it.

@Fusty
Copy link
Author

Fusty commented Oct 10, 2018

@gabbydotCMS I have prepared a branch with the minimal fix required to accommodate this situation.

https://github.com/dotCMS/plugin-com.dotcms.dotsaml/tree/ethode/response-signedness-flips-when-read

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant