From 5fca3eb6c6a0e9bd320a72781c6a6f9342ab5cd4 Mon Sep 17 00:00:00 2001 From: Scott Motte Date: Fri, 3 Nov 2023 23:15:17 -0700 Subject: [PATCH] Adjust logging --- CHANGELOG.md | 8 +++++++- src/DotenvVault.php | 2 +- tests/DotenvVault/DotenvVaultTest.php | 20 -------------------- 3 files changed, 8 insertions(+), 22 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2edef75..ee2c61c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. -## [Unreleased](https://github.com/dotenv-org/phpdotenv-vault/compare/v0.2.3...master) +## [Unreleased](https://github.com/dotenv-org/phpdotenv-vault/compare/v0.2.4...master) + +## 0.2.4 + +### Changed + +- Move logging to `error_log` rather than `echo`. ## 0.2.3 diff --git a/src/DotenvVault.php b/src/DotenvVault.php index 90a3728..1ab8436 100644 --- a/src/DotenvVault.php +++ b/src/DotenvVault.php @@ -180,7 +180,7 @@ public function load() public function _log($message) { - echo "[dotenv-vault][INFO] {$message}"; + error_log("[dotenv-vault][INFO] {$message}"); } public function _loadDotenv() diff --git a/tests/DotenvVault/DotenvVaultTest.php b/tests/DotenvVault/DotenvVaultTest.php index 59ef5e2..4b912b7 100644 --- a/tests/DotenvVault/DotenvVaultTest.php +++ b/tests/DotenvVault/DotenvVaultTest.php @@ -106,71 +106,51 @@ public function testLoadFromEnvFileAndPathsPassedAsString() public function testLoadFromEnvVaultFileWhenDotenvKeyPresent() { - ob_start(); - $_ENV["DOTENV_KEY"] = 'dotenv://:key_ddcaa26504cd70a6fef9801901c3981538563a1767c297cb8416e8a38c62fe00@dotenv.org/vault/.env.vault?environment=development'; $dotenvVault = DotenvVault::createImmutable([__DIR__, self::$folder]); $dotenvVault->load(); self::assertEquals($_ENV['ALPHA'], 'zeta'); - - ob_end_clean(); } public function testLoadFromEnvVaultFileWhenDotenvKeyPresentAndPathsPassedAsString() { - ob_start(); - $_ENV["DOTENV_KEY"] = 'dotenv://:key_ddcaa26504cd70a6fef9801901c3981538563a1767c297cb8416e8a38c62fe00@dotenv.org/vault/.env.vault?environment=development'; $dotenvVault = DotenvVault::createImmutable(self::$folder); $dotenvVault->load(); self::assertEquals($_ENV['ALPHA'], 'zeta'); - - ob_end_clean(); } public function testLoadFromEnvVaultFileWhenDotenvKeyPresentMutable() { - ob_start(); - $_ENV["DOTENV_KEY"] = 'dotenv://:key_ddcaa26504cd70a6fef9801901c3981538563a1767c297cb8416e8a38c62fe00@dotenv.org/vault/.env.vault?environment=development'; $dotenvVault = DotenvVault::createMutable([__DIR__, self::$folder]); $dotenvVault->load(); self::assertEquals($_ENV['ALPHA'], 'zeta'); - - ob_end_clean(); } public function testLoadFromEnvVaultFileWhenDotenvKeyPresentUnsafeImmutable() { - ob_start(); - $_ENV["DOTENV_KEY"] = 'dotenv://:key_ddcaa26504cd70a6fef9801901c3981538563a1767c297cb8416e8a38c62fe00@dotenv.org/vault/.env.vault?environment=development'; $dotenvVault = DotenvVault::createUnsafeImmutable([__DIR__, self::$folder]); $dotenvVault->load(); self::assertEquals($_ENV['ALPHA'], 'zeta'); - - ob_end_clean(); } public function testLoadFromEnvVaultFileWhenDotenvKeyPresentUnsafeMutable() { - ob_start(); - $_ENV["DOTENV_KEY"] = 'dotenv://:key_ddcaa26504cd70a6fef9801901c3981538563a1767c297cb8416e8a38c62fe00@dotenv.org/vault/.env.vault?environment=development'; $dotenvVault = DotenvVault::createUnsafeMutable([__DIR__, self::$folder]); $dotenvVault->load(); self::assertEquals(getenv('ALPHA'), 'zeta'); - - ob_end_clean(); } }