Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ParsingValidationTests.cs to pull the text for the error message from DefaultValidationMessages.cs #2

Closed
MarkMichaelis opened this issue Apr 19, 2018 · 2 comments
Closed

Update ParsingValidationTests.cs to pull the text for the error message from DefaultValidationMessages.cs #2

MarkMichaelis opened this issue Apr 19, 2018 · 2 comments
Assignees
@ykravtsov

Comments

@MarkMichaelis
Copy link
Contributor

MarkMichaelis commented Apr 19, 2018 •
edited
Loading

The result is that the storage of the strings will be concentrated in one place.

To achieve this, it will likely be necessary to make the DefaultValidationMessages class public.
@Keboo
Copy link
Member

Keboo commented May 19, 2018

Take note of the race condition outlined by @natemcmaster

@ykravtsov
Copy link
Contributor

closed with #85

jonsequitur pushed a commit that referenced this issue Jan 18, 2019
@jeredm
Merge pull request #2 from dotnet/master
538360f 
Merge from base
@amoerie amoerie mentioned this issue Nov 9, 2020
Open
5 tasks
@jonsequitur jonsequitur mentioned this issue Aug 27, 2021
Merged
@vlada-shubina vlada-shubina mentioned this issue Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ykravtsov ykravtsov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonsequitur @MarkMichaelis @Keboo @ykravtsov