Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application manifest codebase incorrect when Linux path separator used #132

Open
IGx89 opened this issue Aug 13, 2021 · 1 comment
Open

Comments

@IGx89
Copy link

IGx89 commented Aug 13, 2021

Description

Take these two almost identical commands:

dotnet-mage -update <deployment manifest> -AppManifest Application Files/<application manifest>
dotnet-mage -update <deployment manifest> -AppManifest Application Files\<application manifest>

They both work, but produce different codebase values in the deployment manifest:

<dependentAssembly dependencyType="install" codebase="/Application Files/<application manifest>">

<dependentAssembly dependencyType="install" codebase="Application Files\<application manifest>">

The first one is absolute, breaking the download in every situation except if the deployment manifest is in the root folder of the web site. The second one is relative, functioning correctly. The tool should ideally be smart enough to make the path relative regardless of the path separator used.

Configuration

.NET 5, Windows, x64

Regression?

Unknown

Other information

Here's what appears to be the problematic line of code:

if (codebase.StartsWith("\\"))

@NikolaMilosavljevic
Copy link
Member

I've updated readme to clarify that dotnet-mage is fully supported on Windows. We are gathering feedback about scenarios for usage of the tool on Linux agents.

This and similar issues are very valuable for planning future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants