Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Azurite container ports code example doesn't need two arguments for WithBlobPort, WithTablePort and WithQueuePort #2553

Closed
ianrathbone opened this issue Feb 7, 2025 · 2 comments · Fixed by #2554
Closed

Configure Azurite container ports code example doesn't need two arguments for WithBlobPort, WithTablePort and WithQueuePort #2553

ianrathbone opened this issue Feb 7, 2025 · 2 comments · Fixed by #2554
Assignees
@IEvangelist
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-aspire/svc in-pr okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@ianrathbone
Copy link
Contributor

ianrathbone commented Feb 7, 2025 •
edited by sequestor bot
Loading

Type of issue

Typo

Description

In the section for configuring container ports on Azurite - the code specifies a string for the type configured. This isn't needed in v9 and you can just specify the port

var builder = DistributedApplication.CreateBuilder(args);

var storage = builder.AddAzureStorage("storage").RunAsEmulator(
azurite =>
{
azurite.WithBlobPort("blob", 27000)
.WithQueuePort("queue", 27001)
.WithTablePort("table", 27002);
});

// After adding all resources, run the app...

Page URL

https://learn.microsoft.com/en-us/dotnet/aspire/storage/azure-storage-blobs-integration?tabs=dotnet-cli

Content source URL

https://github.com/dotnet/docs-aspire/blob/main/docs/storage/azure-storage-blobs-integration.md

Document Version Independent Id

9ef62ce9-fb4b-42c8-0914-338a6f4cd5fc

Article author

@IEvangelist

Related Issues

Associated WorkItem - 372042
@ianrathbone
Copy link
Contributor Author

So this could be replaced with:

var builder = DistributedApplication.CreateBuilder(args);

var storage = builder.AddAzureStorage("storage").RunAsEmulator(
azurite =>
{
azurite.WithBlobPort(27000)
.WithQueuePort(27001)
.WithTablePort(27002);
});

@davidfowl
Copy link
Member

Yes

ianrathbone added a commit to ianrathbone/docs-aspire that referenced this issue Feb 7, 2025
@ianrathbone
Fix Azurite container ports code example
5efeaee 
Fixes dotnet#2553

Update Azurite container ports code example to use only one argument for `WithBlobPort`, `WithTablePort`, and `WithQueuePort`.

* Remove the string arguments representing the type configured from the code example in `docs/storage/azure-storage-blobs-integration.md`.
* Specify only the port numbers for `WithBlobPort`, `WithQueuePort`, and `WithTablePort` in the code example.
* Update the code example in `docs/storage/includes/storage-app-host.md` to reflect the changes.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotnet/docs-aspire/issues/2553?shareId=XXXX-XXXX-XXXX-XXXX).
@ianrathbone ianrathbone mentioned this issue Feb 7, 2025
Merged
@IEvangelist IEvangelist self-assigned this Feb 10, 2025
@IEvangelist IEvangelist added 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 doc-bug Problem with the content; needs to be fixed [org][type][category] okr-quality Content-health KR: Concerns article defects/freshness or build warnings. and removed ⌚ Not Triaged Not triaged labels Feb 10, 2025
@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Feb 10, 2025
IEvangelist pushed a commit that referenced this issue Feb 10, 2025
@ianrathbone
Fix Azurite container ports code example (#2554)
49287ff 
Fixes #2553

Update Azurite container ports code example to use only one argument for `WithBlobPort`, `WithTablePort`, and `WithQueuePort`.

* Remove the string arguments representing the type configured from the code example in `docs/storage/azure-storage-blobs-integration.md`.
* Specify only the port numbers for `WithBlobPort`, `WithQueuePort`, and `WithTablePort` in the code example.
* Update the code example in `docs/storage/includes/storage-app-host.md` to reflect the changes.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotnet/docs-aspire/issues/2553?shareId=XXXX-XXXX-XXXX-XXXX).
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Feb 11, 2025
IEvangelist pushed a commit that referenced this issue Feb 11, 2025
@ianrathbone @IEvangelist
Fix Azurite container ports code example (#2554)
0ccb587 
Fixes #2553

Update Azurite container ports code example to use only one argument for `WithBlobPort`, `WithTablePort`, and `WithQueuePort`.

* Remove the string arguments representing the type configured from the code example in `docs/storage/azure-storage-blobs-integration.md`.
* Specify only the port numbers for `WithBlobPort`, `WithQueuePort`, and `WithTablePort` in the code example.
* Update the code example in `docs/storage/includes/storage-app-host.md` to reflect the changes.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotnet/docs-aspire/issues/2553?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IEvangelist IEvangelist

Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-aspire/svc in-pr okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
dotnet/docs February 2025 sprint project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Azurite container ports code example ianrathbone/docs-aspire
3 participants
@davidfowl @ianrathbone @IEvangelist