Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Custom Templates topic sample consistent #3175

Closed
guardrex opened this issue Sep 18, 2017 · 8 comments
Closed

Make Custom Templates topic sample consistent #3175

guardrex opened this issue Sep 18, 2017 · 8 comments
Labels
blocked Blocked for some reason doc-enhancement Improve the current content [org][type][category]
Milestone

Comments

@guardrex
Copy link
Contributor

The Custom Templates topic sample isn't consistent with the other templates in the dotnet-template-samples repo. Topic work tracked here by this issue. The templates repo work tracked by dotnet/dotnet-template-samples#29.

@mairaw I'll work on this if it's ok with you. I can't really call this a mistake, since the sample wasn't intended to be part of the templates repo when I wrote the topic and built the sample; however, I feel a measure of responsibility to make it consistent.

https://docs.microsoft.com/dotnet/core/tools/custom-templates
docs/core/tools/custom-templates.md

@guardrex
Copy link
Contributor Author

btw- This work is blocked by dotnet/dotnet-template-samples#29, so I'll track on that and then solve this issue after the naming scheme is resolved there.

@mairaw mairaw added Area - .NET Core Guide blocked Blocked for some reason doc-enhancement Improve the current content [org][type][category] labels Sep 20, 2017
@mairaw
Copy link
Contributor

mairaw commented Sep 20, 2017

Thanks @guardrex. You're way more familiar with that than I am so, of course, I welcome your contribution!

@mairaw mairaw added this to the 2017 - Quarter 4 milestone Sep 20, 2017
@mairaw mairaw modified the milestones: 2017 - Quarter 4, Backlog Jan 4, 2018
@mairaw mairaw added the P2 label Jan 4, 2018
@mairaw
Copy link
Contributor

mairaw commented Jan 4, 2018

It seems that the blocking issue is still open so moving to backlog.

@guardrex
Copy link
Contributor Author

guardrex commented Jan 4, 2018

@mairaw I'll be free after the 18th. I'll TAL over there and probably offer to [@]sayedihashimi to make all of them consistent. Once they're stable over there, I'll mirror the sample over here with the changes.

@mairaw
Copy link
Contributor

mairaw commented Jan 4, 2018

Not sure who's taking over that area. I saw today that he's moving to another team.

@guardrex
Copy link
Contributor Author

guardrex commented Jan 5, 2018

Ah ... I see. I'll check in with them over there right after the contract ends and see if there's an opportunity for me to fix them up. I'll let you know how it turns out.

@guardrex
Copy link
Contributor Author

guardrex commented Feb 1, 2018

@mairaw I was just looking over the templates in the dotnet/dotnet-template-samples because I was about to ask over there if they need/want help with consistency.

WRT the topic over here, the following few entries are a bit more real-world than what they'll end up with over there (e.g., MyProject.01.Sample.CSharp). It just boils down for this topic to what is shown for ...

{
  "$schema": "http://json.schemastore.org/template",
  "author": "Catalina Garcia",
  "classifications": [ "Common", "Console" ],
  "identity": "GarciaSoftware.ConsoleTemplate.CSharp",
  "name": "Garcia Software Console Application",
  "shortName": "garciaconsole"
}

... and that's really probably ok over here.

The problem really seems to be consistency within their template sample set, especially the way this particular sample was just shoved in over there, plus some other consistency problems within the first 15 samples they have.

Perhaps it's best just to close this. I don't see any detriment to readers using Ms. Catalina's example here.

[EDIT] Can't wait on that repo anyway. It doesn't seem to be monitored by anyone. They have old outstanding open PRs.

@tdykstra
Copy link
Contributor

tdykstra commented Jun 5, 2020

Perhaps it's best just to close this.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked for some reason doc-enhancement Improve the current content [org][type][category]
Projects
None yet
Development

No branches or pull requests

4 participants