Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace nitpicks introduced in #2048 #2082

Open
nagilson opened this issue Jan 6, 2025 · 1 comment · May be fixed by #2088
Open

Fix whitespace nitpicks introduced in #2048 #2082

nagilson opened this issue Jan 6, 2025 · 1 comment · May be fixed by #2088

Comments

@nagilson
Copy link
Member

nagilson commented Jan 6, 2025

So that we can merge #2048, I'm writing this issue to resolve the nitpicks here. We'd like to merge this PR now for release, but the pipeline needs to be remedied as well. To stick to the release cycle and avoid fixing the pipeline in that PR, I've created an issue here to followup on the nits.
@nagilson nagilson mentioned this issue Jan 6, 2025
Merged
@nagilson
Copy link
Member Author

nagilson commented Jan 6, 2025

Also #2048 (comment) see this for a refactoring suggestion.

nagilson added a commit to nagilson/vscode-dotnet-runtime that referenced this issue Jan 13, 2025
@nagilson
Fix whitespace and other code style no's
e5b02aa 
Please see dotnet#2082

I'll use this as an opportunity to introduce a needed perf improvement per a request from another team as well since we are in the business of improving the code.

taskkill is currently called all of the time. I added that task kill only to kill timed out installer processes (dotnet@43f7494#r1669397622), but the code seems to run at times when I wouldn't expect it to. It likely doesn't need to be run at all, I can put a condition on it.
@nagilson nagilson linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nagilson