Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This like native feature #68

Open
okvic77 opened this issue Nov 3, 2015 · 2 comments
Open

This like native feature #68

okvic77 opened this issue Nov 3, 2015 · 2 comments

Comments

@okvic77
Copy link

okvic77 commented Nov 3, 2015

Hi,

I like this gulp pipe, but there is a problem with the styles @url files. They are not imported. The copy function is not the best, they can't "rev" the files and change the link in the styles.

I done this https://github.com/okvic77/gulp-bundle-assets-append
The url of the styles are hashed and the reference is updated. See the Travis build for an example.

This could be a native feature in this plugin.

@chmontgomery
Copy link
Contributor

@okvic77 have you tried using gulp-rework as part of the custom transform instead of using rework directly? It seems gulp-rework takes care of importing the files for you, i.e.: https://github.com/sindresorhus/gulp-rework/blob/master/index.js#L25

@okvic77
Copy link
Author

okvic77 commented Nov 15, 2015

I'll try, but how I can attach a new file (font files) to the pipe but skip some process like gulp-rev, or wait for gulp-rev and then replace the link in the file (vinyl).

Is there a way right now?

For example, like a vinyl object property like vinylFile.skip = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants