Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could this be a pure JavaScript package instead? #18

Open
brodycj opened this issue May 8, 2017 · 1 comment
Open

Could this be a pure JavaScript package instead? #18

brodycj opened this issue May 8, 2017 · 1 comment

Comments

@brodycj
Copy link

brodycj commented May 8, 2017

@dpa99c I just discovered this plugin from Ionic-native. I would like to start with a note of appreciation for your hard work to help people deal with some of the issues they encounter with sqlite and Cordova in general. I made a small donation and would like to give you a word of encouragement to keep up the good work. I am sure your work will be recognized more and more over time.

Looking at this project I see that it could be just as useful for either Cordova or Web SQL in the browser. While the Web SQL spec is unfortunately deprecated and not supported by some newer browsers such as Edge I can imagine some possible uses including:

Ideally it should be possible to consume as a CommonJS (ES5) module or ES6 module by systems such as Browserify, Webpack, Rollup, or prepack.io. You may want to look at what I did in https://github.com/brodybits/sql-promise-helper in the past.

I would love to make this contribution but am pretty swamped with backlog right now.

@dpa99c
Copy link
Owner

dpa99c commented May 9, 2017

@brodybits Firstly, thanks for the donation - it's much appreciated, as are your kind words.

I originally created this plugin out of my own necessity when building Cordova apps that used SQLite storage. However, you're right in that it could be generalised into being non-Cordova-specific so it would work in browser, node environments, etc. It's something I'd considered may be useful, but I've not had need of it myself.

This repo contains some Cordova-specific bits, both in the documentation and files such as plugin.xml, so I think if the core functionality were to be generalised, it should live in a different repo (sqlite-porter?).

Like yourself, I am also pretty swamped with backlog: in addition to my day job, I have my own apps in the app stores, as well as my open source software to maintain. What you propose makes sense, so I will add it to the TODO list and get around to it when I eventually have some time.

alexhisen added a commit to alexhisen/cordova-sqlite-porter that referenced this issue Aug 31, 2019
alexhisen added a commit to alexhisen/cordova-sqlite-porter that referenced this issue Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants