Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for feedback on NixOS package #129

Open
hughobrien opened this issue Aug 24, 2024 · 4 comments
Open

Request for feedback on NixOS package #129

hughobrien opened this issue Aug 24, 2024 · 4 comments

Comments

@hughobrien
Copy link

Hey guys, thank you so much for this work.

I'd like to port this to Nix/NixOS, and have an open PR NixOS/nixpkgs#337069

Would appreciate any feedback!

Please feel free to close this issue.
@LupertEverett
Copy link
Contributor

LupertEverett commented Aug 25, 2024 •
edited
Loading

I checked out the PR you've linked, and noticed this particular line:

Note the binary requires SurrealEngine.pk3 to be available on the path. I tried adding to $out/lib but no dice. Open to suggestions/wrappers to keep it out of bin

We can add additional folders to check for SurrealEngine.pk3 on Linux. How does /usr/share/surrealengine sound?

@LupertEverett LupertEverett mentioned this issue Aug 25, 2024
Merged
@hughobrien
Copy link
Author

Perfect, I can patch that as part of the build which is pretty standard on NixOS. PR updated.

@LupertEverett
Copy link
Contributor

Just noticed the PR got closed. Did something happen?

@hughobrien
Copy link
Author

It got stale, I'll re-open it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hughobrien @LupertEverett