Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINEARRING confuses Line Overlay #6

Open
pramsey opened this issue Aug 8, 2020 · 2 comments
Open

LINEARRING confuses Line Overlay #6

pramsey opened this issue Aug 8, 2020 · 2 comments

Comments

@pramsey
Copy link

pramsey commented Aug 8, 2020

Running the existing XML tests using SnapIfNecessary (aka, making OverlayNG the default overlay implementation) and this case is an interesting failure.

	Description: GC - shows handling linear rings and linestrings
	Geometry A: GEOMETRYCOLLECTION (LINEARRING (0 0, 0 70, 80 70, 80 0, 0 0), LINESTRING (30 110, 30 30, 100 30))
	Expected result: MULTILINESTRING ((0 0, 0 70, 30 70), (30 70, 80 70, 80 30), (80 30, 80 0, 0 0), (30 110, 30 70), (30 70, 30 30, 80 30), (80 30, 100 30))
	Obtained result: LINESTRING (30 110, 30 30, 100 30)

When you change the input A from a LINEARRING to a LINESTRING the failure goes away. There's at least one other LINEARRING failure case in GEOS XML test suite, but this one seems good and illustrative.

@dr-jts
Copy link
Owner

dr-jts commented Aug 8, 2020

That is a test of UnaryUnion, in case not clear.

JTS produces the expected result using OverlayNG UnaryUnion (either called directly, or as part of OverlayNGSnapIfNeeded - not surprising, since there is no snapping invoked for this case).

So it looks like this might be a GEOS-only thing?

@pramsey
Copy link
Author

pramsey commented Aug 8, 2020

Damn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants