-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi language support #30
Comments
@easazade Makes sense and sounds like good addition. Feel free to send a PR! |
@drager Great, do you have any suggestion on how to approach implementing feature? I'm thinking something like this for example : faker.languages.farsi.words(3) |
Good question! I think we should first of look at other faker implementations and get ideas from them. Do for example the python/ruby package supports LTR? If they do, perhaps their way is a good starting point. If they don't, then perhaps |
@drager I checked. Python package supports Localization of Data and implemented it using different here is what they do : from faker import Faker
fake = Faker('it_IT')
for _ in range(10):
print(fake.name())
# 'Elda Palumbo'
# 'Pacifico Giordano'
# 'Sig. Avide Guerra'
# 'Yago Amato'
# 'Eustachio Messina'
# 'Dott. Violante Lombardo'
# 'Sig. Alighieri Monti'
# 'Costanzo Costa'
# 'Nazzareno Barbieri'
# 'Max Coppola' |
Awesome, that seems like a good way of doing it? Or what do you think? 😊 |
@drager I was thinking we should add |
@drager thanks for the merge. I will start adding |
@easazade Thank you! Sounds great! |
I would like to help with portuguese br translation when available. |
@rumbleh Feel free to work on it! |
next time I contributed in order to finish this. I remember to add some documentation. |
Is anyone working on this? I would love to give it a go if nobody is working on it. I'm wanting to localize it for randomizing Spanish data |
@nombrekeff thank you for the comment. reminded me there is unfinished work to be done here. I decided to add the rest of the data providers to other data generators like address , food job and etc. after that everyone can add their own customized |
I should also update the docs |
Ohh cool 👍 Thanks for the info, I will check it out when it's ready. Let me know if I can help in any other way, adding translations, docs, etc... I have some free time at the moment and would be glad to help out! |
hey @nombrekeff |
it will be great to add support for other languages as well.
though I understand that there are alot of languages and comming up with a solution to this problem can be hard.
one problem is that some languages are RTL (like farsi aka persian) unlike english which is LTR. and developers who make their app
RTL first
will override the flutter app locale to show the entire app in RTL. because of this showing faker's fake text which are read from left to right (LTR) because they are in english in an app which loaded its entire widget tree in (RTL) is very confusing.The text was updated successfully, but these errors were encountered: