-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer missing from PostView #67
Comments
This should be addressed with #69, note that it seems there are a few more As you're building a full blown client based off of this library, and these fields are more out of the range of what I usually use this library for myself (Ex. Bot activity and posting), IMO, I would submodule this, add the missing fields as you see them for your app, and PR them back if you like. That would unblock you and not rely on me to make these changes. Of course you can keep filing issues (Although if you could please post example JSON you're seeing, AT-URIs, etc, that would be nicer than just posting a link to the lexicon), but your at my time for doing it. Thanks! |
Yeah, I considered it, but I was trying to avoid submodules as I don't really like working with them + don't want to publish a fork of a package to NuGet. I'll keep it in mind for the future.
I'm fine with waiting if you're okay with more issues 😄, but I can PR them if I end up going down the fork route. |
See here.
The text was updated successfully, but these errors were encountered: