From 7ebc7fd71b7360fd84591ddba8b787ae0fce0683 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Mon, 30 Sep 2024 10:23:45 -0400 Subject: [PATCH] Fix `make table-check` command and regenerate tables (#1441) --- Makefile | 2 +- docs/resource/cloudfoundry.md | 4 ++-- model/file/registry.yaml | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 680baa7fda..4e4a64d350 100644 --- a/Makefile +++ b/Makefile @@ -150,7 +150,7 @@ table-check: --mount 'type=bind,source=$(PWD)/model,target=/home/weaver/source,readonly' \ --mount 'type=bind,source=$(PWD)/docs,target=/home/weaver/target,readonly' \ $(WEAVER_CONTAINER) registry update-markdown \ - --registry=/home/weaver/target \ + --registry=/home/weaver/source \ --attribute-registry-base-url=/docs/attributes-registry \ --templates=/home/weaver/templates \ --target=markdown \ diff --git a/docs/resource/cloudfoundry.md b/docs/resource/cloudfoundry.md index a6cd9f241b..7a6f04bc29 100644 --- a/docs/resource/cloudfoundry.md +++ b/docs/resource/cloudfoundry.md @@ -190,7 +190,7 @@ tasks or side-cars with different process types. | [`cloudfoundry.system.id`](/docs/attributes-registry/cloudfoundry.md) | string | A guid or another name describing the event source. [1] | `cf/gorouter` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | | [`cloudfoundry.system.instance.id`](/docs/attributes-registry/cloudfoundry.md) | string | A guid describing the concrete instance of the event source. [2] | `218fc5a9-a5f1-4b54-aa05-46717d0ab26d` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -**[1]:** CloudFoundry defines the `source_id` in the [Loggegator v2 envelope](https://github.com/cloudfoundry/loggregator-api#v2-envelope). +**[1]:** CloudFoundry defines the `source_id` in the [Loggregator v2 envelope](https://github.com/cloudfoundry/loggregator-api#v2-envelope). It is used for logs and metrics emitted by CloudFoundry. It is supposed to contain the component name, e.g. "gorouter", for CloudFoundry components. @@ -200,7 +200,7 @@ When system components are instrumented, values from the should be used. The `system.id` should be set to `spec.deployment/spec.name`. -**[2]:** CloudFoundry defines the `instance_id` in the [Loggegator v2 envelope](https://github.com/cloudfoundry/loggregator-api#v2-envelope). +**[2]:** CloudFoundry defines the `instance_id` in the [Loggregator v2 envelope](https://github.com/cloudfoundry/loggregator-api#v2-envelope). It is used for logs and metrics emitted by CloudFoundry. It is supposed to contain the vm id for CloudFoundry components. diff --git a/model/file/registry.yaml b/model/file/registry.yaml index 49049cdd6c..cf138ba9a3 100644 --- a/model/file/registry.yaml +++ b/model/file/registry.yaml @@ -20,7 +20,8 @@ groups: Attributes names depend on the OS or file system. Here’s a non-exhaustive list of values expected for this attribute: `archive`, `compressed`, `directory`, `encrypted`, `execute`, `hidden`, `immutable`, `journaled`, `read`, `readonly`, `symbolic link`, `system`, `temporary`, `write`. stability: experimental - examples: ['readonly', 'hidden'] + examples: + - ['readonly', 'hidden'] - id: file.created type: string brief: >