Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner Top region multilingual update #417

Open
2 tasks
Decipher opened this issue Apr 27, 2022 · 0 comments · May be fixed by #418
Open
2 tasks

Banner Top region multilingual update #417

Decipher opened this issue Apr 27, 2022 · 0 comments · May be fixed by #418
Labels
bug Something isn't working enhancement New feature or request

Comments

@Decipher
Copy link
Member

Describe the bug
The BannerTop region theme component has the expected blocks and visibility conditions explicitly set, taking away control from the Drupal blocks configuration.

It's been implemented this way as a workaround for the Path visibility settings not working due to lack of Multilingual support.

To Reproduce
https://github.com/druxt/demo.druxtjs.org/blob/develop/components/druxt/block-region/BannerTop.vue

Expected behavior

  • A default region fallback that replaces the BannerTop.vue component?
  • Iterate over slots and use a modified visibility check to compensate for the language prefix

Media
N/A

Your Environment (please complete the following information):
N/A

Additional context
Ideally multilingual support should prevent the need for this theme component: druxt/druxt.js#158

@Decipher Decipher added bug Something isn't working enhancement New feature or request labels Apr 27, 2022
@Decipher Decipher linked a pull request Apr 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant