-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review HW2 #2
Comments
[I think the format for the previous paragraph was massed up a little bit so I have it deleted.] Your codes look great, all codes are good, except that maybe you should consider organizing your code a bit differently. When you have those long codes with multiple pipes, you do it as a single long line. It doesn't affect the result you get, but it can be hard to read and organize. If you ever want to insert some steps in between, it can be a bit hard to do. The code looks good, but it's kind of hard to read and organize, I think it would be better if you can do: For 4.19, I really like how you insert the names and ends of presidency in your graph. It presents the relationship between presidency and popularity of the names even better. Nice work. For 4.4, I personally don't think a full join is needed here. But both ways should work. Good Work |
4.4 Oops. I just reread the question. I think your idea is right, we do need to join two tables together, but I don't think it should be full join. The question asked: |
Thanks. I think I misunderstood what the planes dataset represented, which is why I used the full join. Re: line breaks I agree and I forgot that what the code looks like in Rstudio isn't quite how it comes out when knitted. I will definitely make sure to do a new line for every pipe from now on. |
I just went and fixed the line breaks because it was annoying me. |
@wxindu sorry I'm tagging you so late
The text was updated successfully, but these errors were encountered: