Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-glob should always be fed absolute paths #59

Open
ds300 opened this issue Apr 19, 2023 · 0 comments
Open

fast-glob should always be fed absolute paths #59

ds300 opened this issue Apr 19, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ds300
Copy link
Owner

ds300 commented Apr 19, 2023

It turns out that globbing (or maybe, rather, micromatch) behaves in odd ways when you mix absolute and relative paths while passing both implicit and explicit cwd. We should make sure we're always giving fast-glob absolute paths, just to be safe. Then the cwd arg becomes moot so it can be elided.

Look into adding a wrapper around glob.sync to assert that all include and ignore patterns are absolute. Audit all existing usages of fast-glob.

@ds300 ds300 converted this from a draft issue Apr 19, 2023
@ds300 ds300 added the good first issue Good for newcomers label Apr 19, 2023
@ds300 ds300 moved this from 🔖 Ready to ✅ Done in lazyrepo road to beta May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

1 participant