-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Tag Name When Deleting Closing Tag #29
Comments
Same here, self-closing tags are impossible. Similar to #25. A simple fix for this bug, that basically renders the plugin un-useable, is to disable the functionality when editing closing tags. I think we can all manage to modify opening tags when we want it replicated to the closing tags. |
Looks like PR #28 aims to alleviate this problem as well. |
@arctelix Please elaborate. If you are finding that there are certain tags that you never want this package to operate on, add them to Disabling end tag sync has been added to v1.1.0. |
v1.1.0 Seems to have fixed the issue. Thanks! In the future, it would be great if double tag could differentiate between modifying a closing tag (causing the opening tag to change) and deleting a closing tag (causing the opening tag to become self-closing). That should eliminate the need for the configuration and satisfy all use cases ( i think ). |
This bug is now hitting me in vim-mode. When I remove the line that has the closing tag on it, the opening tag's text gets removed. Furthermore, undo doesn't add the text back. |
If i'm editing code, and cut the closing tag (for example to past it somewhere else in the code), it deletes that tag name from the opening tag, leaving me with a malformed tag:
becomes this, after cutting the closing tag:
The text was updated successfully, but these errors were encountered: