Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Atom 1.31.1? #45

Closed
AxDSan opened this issue Oct 2, 2018 · 5 comments
Closed

Not working on Atom 1.31.1? #45

AxDSan opened this issue Oct 2, 2018 · 5 comments

Comments

@AxDSan
Copy link

AxDSan commented Oct 2, 2018

Having this issue.

How to reproduce:

  • Download latest Atom
  • Work on some files.
  • Install the package
  • Try to change a tag; It won't update.

Also I need a little help understanding what's up with the scope thing?
I thought that this would automatically look up for changes in tags in HTML or any other, but what does it really means? do I have to have a file named text.html?

@dsandstrom
Copy link
Owner

People have reported that this doesn't work on new files, but I can't really reproduce. Did you restart Atom after installing this package?

If you are working on html and erb files, you don't need to add anything to the scope settings. The reason it's not enabled for all files is to not degrade performance unnecessarily. I'm not sure if this works natively on Django files, I don't have any experience. However, you can add it's scope to the package's settings. See #44 for more info.

@AxDSan
Copy link
Author

AxDSan commented Oct 3, 2018

People have reported that this doesn't work on new files, but I can't really reproduce. Did you restart Atom after installing this package?

If you are working on html and erb files, you don't need to add anything to the scope settings. The reason it's not enabled for all files is to not degrade performance unnecessarily. I'm not sure if this works natively on Django files, I don't have any experience. However, you can add it's scope to the package's settings. See #44 for more info.

Yes I have tested it in every way possible, uninstalling, reinstalling, closing the editor, opening it back up, editing old files and nothing... here's a gif showing:

@dsandstrom
Copy link
Owner

Does it work if the syntax is straight "HTML". Please try on an HTML file, not a Django file. My theory is you need to add the right syntax string to the settings.

@AxDSan
Copy link
Author

AxDSan commented Oct 3, 2018

It Works!

I created a pure HTML file and changed the syntax in the syntax selector, restarted and viola!


Hmm, now... how do I add django html files? or that's something you have to work on?

@dsandstrom
Copy link
Owner

Sweet, thanks for following up.

There is no inherit support for Django, you will have to add the syntax string to the package's settings. The documentation is lacking for this, but #44 has a bit more info.

Please let me know what string works so I can add it to the package for future Django users.

@AxDSan AxDSan closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants