Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureDevOpsDsc: Fix style so it follows style guideline #29

Open
johlju opened this issue Jan 29, 2021 · 1 comment
Open

AzureDevOpsDsc: Fix style so it follows style guideline #29

johlju opened this issue Jan 29, 2021 · 1 comment
Labels
Backlog - Mid Term Backlog - Mid Term enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Jan 29, 2021

We should look at the style guideline and compare it to the code to see what areas need to accommodate for PowerShell classes, and also modify the code towards the style guideline.
We should do this before we get to many resources that diverge to much from the style guideline.

https://dsccommunity.org/styleguidelines/

We could use this issue to list the suggested additions to the style guideline, or accommodations. I can help make the appropriate changes to the style guideline.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jan 29, 2021
@johlju johlju mentioned this issue Jan 31, 2021
Open
@johlju
Copy link
Member Author

johlju commented Jan 31, 2021 •
edited
Loading

Add to style guideline: Properties that are Key should not also be set to Mandatory as Key is implicitly mandatory.

@kilasuit kilasuit added the Backlog - Mid Term Backlog - Mid Term label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backlog - Mid Term Backlog - Mid Term enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kilasuit @johlju