Optimize for_each_element folded loops #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vksnk
approved these changes
Feb 12, 2025
dsharlet
added a commit
that referenced
this pull request
Feb 13, 2025
…603) #602 allowed folded innermost dimensions that are contiguous to be passed to `for_each_contiguous_slice` callbacks, but not non-innermost dimensions. This PR fixes that. It is a small regression in unaffected cases due to the parameter being passed through each loop implementation function even when it isn't used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we evaluate folded loops very simply, by evaluating each iteration independently. This has high overhead, especially for
for_each_contiguous_slicewhere the folded dimension is contiguous.This PR adds logic to call the callbacks on linear chunks at a time when possible: