-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider contributing to Apache Camel #1
Comments
Hi, Except that a bit of polishing would be needed to fulfil the contribution requirements of Camel, afaik. [1] https://issues.jboss.org/browse/UNDERTOW-238 |
Oh its okay for a Camel component not to support OSGi. There is a few that does that. |
I see this more valuable as a microcontainer way where you bootup Camel with undertow as the http server - not as much for usage in osgi/karaf. |
Hi, I've prepared initial code for PR. May I proceed to get some feedback on it? |
Looks great. A few comments
|
PR submitted apache/camel#562 |
Thanks a lot I have merged the code to master branch. I did a few polish and added some TODO what to do still. The unit tests should really use dynamic port number, we have some port finder code in camel-test that we use in the other http components such as camel-jetty9, camel-http4, camel-ahc or whatnot. For the async routing engine I may take a look as its a bit complicated for new users. But of course you are welcome to take a stab at that too. You can be inspired in the jetty http producer code that does that. |
Thanks, I'll look into unit tests and other TODOs and try to do my best. |
I just pushed the async code change to camel master branch. As the unit test was actually wrong from the start it surfaces the problem. The producer returns its own response, instead of the response from the server. So there is a bunch of tests that fails now. You are welcome to take a look I fixed UndertowComponentTest to be correct. Also you should
|
I think, the problem was that I'll keep this issue open for now. |
Hi
How is it going? I wonder if you want to contribute your work to ASF?
We have a ticket about a camel-undertow component
https://issues.apache.org/jira/browse/CAMEL-6577
And your work would be a good starting point to get this done?
Are you aware of any work still to be done in this component? And what else you may see as being needed to be done?
The text was updated successfully, but these errors were encountered: