From a57f4636bf8b38c430c2d64e7478c74c70ccc4b9 Mon Sep 17 00:00:00 2001 From: peterschmidt85 Date: Wed, 2 Aug 2023 11:15:52 +0200 Subject: [PATCH] - [CLI]: Bug: Doesn't run a dev environment if code is not configured in PATH #612 --- cli/dstack/_internal/configurators/dev_environment.py | 4 +++- cli/dstack/_internal/configurators/extensions/vscode.py | 9 +++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/cli/dstack/_internal/configurators/dev_environment.py b/cli/dstack/_internal/configurators/dev_environment.py index ddf2d0a06..f33ebb36e 100644 --- a/cli/dstack/_internal/configurators/dev_environment.py +++ b/cli/dstack/_internal/configurators/dev_environment.py @@ -29,7 +29,9 @@ def get_jobs( run_plan: Optional[RunPlan] = None, ) -> List[job.Job]: self.ide = VSCodeDesktop( - extensions=["ms-python.python", "ms-toolsai.jupyter"], run_name=run_name + extensions=["ms-python.python", "ms-toolsai.jupyter"], + run_name=run_name, + run_plan=run_plan, ) self.sshd = SSHd(ssh_key_pub) self.sshd.map_to_port = get_map_to_port(self.ports(), self.sshd.port) diff --git a/cli/dstack/_internal/configurators/extensions/vscode.py b/cli/dstack/_internal/configurators/extensions/vscode.py index f32875b58..591ae91ee 100644 --- a/cli/dstack/_internal/configurators/extensions/vscode.py +++ b/cli/dstack/_internal/configurators/extensions/vscode.py @@ -3,16 +3,21 @@ from dstack._internal.cli.utils.common import console from dstack._internal.configurators.extensions import IDEExtension +from dstack._internal.core.plan import RunPlan class VSCodeDesktop(IDEExtension): def __init__( - self, extensions: List[str], version: Optional[str] = None, run_name: Optional[str] = None + self, + extensions: List[str], + version: Optional[str] = None, + run_name: Optional[str] = None, + run_plan: Optional[RunPlan] = None, ): self.extensions = extensions if version is None: version = self._detect_code_version() - if version is None: + if version is None and run_plan is None: console.print( "[grey58]Unable to detect the VS Code version and pre-install extensions. " "Fix by opening [sea_green3]Command Palette[/sea_green3], executing [sea_green3]Shell Command: "