Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix Grid-Stat segfault when SEEPS is the only NetCDF output type requested #3020

Open
10 of 23 tasks
JohnHalleyGotway opened this issue Nov 15, 2024 · 0 comments · May be fixed by #3021 or #3022
Open
10 of 23 tasks

Bugfix: Fix Grid-Stat segfault when SEEPS is the only NetCDF output type requested #3020

JohnHalleyGotway opened this issue Nov 15, 2024 · 0 comments · May be fixed by #3021 or #3022
Assignees
Labels
MET: Grid-to-Grid Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Nov 15, 2024

Describe the Problem

As described in discussion dtcenter/METplus#2794, Grid-Stat segfaults when SEEPS is the only NetCDF output type requested. Grid-Stat attempts to write the SEEPS data to the NetCDF output file prior to that file being created.

Remember to fix this in both the develop and main_v12.0 branches.

Expected Behavior

This issue is to update the Grid-Stat logic to create and initialize the NetCDF output file, even if SEEPS is the only type requested.

Environment

Describe your runtime environment:

  • Identified by the MetOffice and replicated on seneca.

To Reproduce

Describe the steps to reproduce the behavior:

Relevant Deadlines

Include fix in the MET-12.0.0 release.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working requestor: UK Met Office United Kingdom Met Office alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Grid-to-Grid Verification priority: high High Priority labels Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Nov 15, 2024
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.0.0 Development Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🏗 In progress in MET-12.0.0 Development Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 15, 2024
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
… determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 15, 2024 that will close this issue
17 tasks
JohnHalleyGotway added a commit that referenced this issue Nov 15, 2024
… determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 15, 2024 that will close this issue
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 🔎 In review in MET-12.0.0 Development Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Grid-to-Grid Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Projects
Status: 🔎 In review
2 participants