From 7b6d9d76ecb3dd71b25429bd2f038e1391bc3a1c Mon Sep 17 00:00:00 2001 From: Xiaomeng Zhang Date: Thu, 28 Jan 2021 15:15:35 +0000 Subject: [PATCH] Readd log lines for first retryable error (#955) Summary: We removed the error details from the logline in previous commit. However, this log line is essential to our retry logic since we are doing string matching to determine how worker is going to do the retry. This commit is to add the first error back to the log line. Test Plan: Build and verify the logline --- .../org/datatransferproject/transfer/CallableImporter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/portability-transfer/src/main/java/org/datatransferproject/transfer/CallableImporter.java b/portability-transfer/src/main/java/org/datatransferproject/transfer/CallableImporter.java index 6da00ceb5..353ce5368 100644 --- a/portability-transfer/src/main/java/org/datatransferproject/transfer/CallableImporter.java +++ b/portability-transfer/src/main/java/org/datatransferproject/transfer/CallableImporter.java @@ -71,10 +71,10 @@ public ImportResult call() throws Exception { success = result.getType() == ImportResult.ResultType.OK && errors.isEmpty(); if (!success) { - // No need to log out individual errors - // since IdempotentImportExecutor already logs them out throw new IOException( - "Encountered errors in idempotentImportExecutor, forcing a retry"); + "Problem with importer, forcing a retry, " + + "first error: " + + (errors.iterator().hasNext() ? errors.iterator().next() : "none")); } result = result.copyWithCounts(data.getCounts());