Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Get thumbnail from uploaded video #4

Open
Strit opened this issue Jan 22, 2018 · 4 comments
Open

[Feature Request] Get thumbnail from uploaded video #4

Strit opened this issue Jan 22, 2018 · 4 comments

Comments

@Strit
Copy link

Strit commented Jan 22, 2018

Hi.

I'd like to request the ability to choose a thumbnail from the uploaded video, instead of always having to choose a picture, from my device.

This would make it easier to do do quick uploads, where a flashy thumbnail is not needed.

@softlair38
Copy link
Contributor

Hi. Dtube let you choose a image from the video source I think no?

@Strit
Copy link
Author

Strit commented Feb 17, 2018

Maybe if it's in a format like mp4. But would be great to have the option for other formats aswell.
For example I always use mkv for my video files.
Codecs is x264 for video and ogg for audio. And I don't get the option.

@softlair38
Copy link
Contributor

Ok. We already think and work on it. Perhaps it will be to choose a time and the uploader will extract the image at this time. Thank you for your message

@skzap
Copy link
Member

skzap commented Feb 21, 2018

YouTube does it this way and proposes 3 snapshots of the video to the user after the end of the video processing.

This has major cons for us:

  • We store files on IPFS, therefore we would ipfs add two useless files on each upload
  • It creates more centralized logic, and in this case this logic here would be a point of failure. If it stops working correctly, no one can upload.
  • Creates more work load in the /uploadVideo call (which is already heavy)

As long as the normal snap upload keeps existing, I don't have much problems against this feature. It could be useful to a lot of people, and replace our current 'take snap' feature that isn't very intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants