From b48be37684bfc520d753f554c3c11bc2d8c45612 Mon Sep 17 00:00:00 2001 From: Aleksandar Milicevic Date: Wed, 25 Oct 2023 19:04:29 +0000 Subject: [PATCH] adapt readme; add default materialization config --- dbt/adapters/duckdb/environments/local.py | 2 +- dbt/adapters/duckdb/plugins/__init__.py | 3 +++ dbt/adapters/duckdb/plugins/delta.py | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dbt/adapters/duckdb/environments/local.py b/dbt/adapters/duckdb/environments/local.py index 34560074..abfead8f 100644 --- a/dbt/adapters/duckdb/environments/local.py +++ b/dbt/adapters/duckdb/environments/local.py @@ -115,7 +115,7 @@ def load_source(self, plugin_name: str, source_config: utils.SourceConfig): df = plugin.load(source_config) assert df is not None - materialization = source_config.meta.get("materialization", "table") + materialization = source_config.meta.get("materialization", plugin.default_materialization()) source_table_name = source_config.table_name() df_name = source_table_name.replace(".", "_") + "_df" diff --git a/dbt/adapters/duckdb/plugins/__init__.py b/dbt/adapters/duckdb/plugins/__init__.py index 183c8693..2520173b 100644 --- a/dbt/adapters/duckdb/plugins/__init__.py +++ b/dbt/adapters/duckdb/plugins/__init__.py @@ -121,3 +121,6 @@ def configure_cursor(self, cursor): :param cursor: A DuckDBPyConnection instance to be configured. """ pass + + def default_materialization(self): + return "table" diff --git a/dbt/adapters/duckdb/plugins/delta.py b/dbt/adapters/duckdb/plugins/delta.py index db4df705..ffcf1312 100644 --- a/dbt/adapters/duckdb/plugins/delta.py +++ b/dbt/adapters/duckdb/plugins/delta.py @@ -40,6 +40,8 @@ def load(self, source_config: SourceConfig): return df + def default_materialization(self): + return "view" # Future # TODO add databricks catalog