Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PG int type to represent DuckDB tinyint type #594

Open
JelteF opened this issue Feb 14, 2025 · 0 comments
Open

Use PG int type to represent DuckDB tinyint type #594

JelteF opened this issue Feb 14, 2025 · 0 comments
Labels
good first issue Good for newcomers types Issues related to type conversions

Comments

@JelteF
Copy link
Collaborator

JelteF commented Feb 14, 2025

Description

We're currently representing tinyint as bpchar. While that saves on the, it means it is not displayed as a number but as a hex character by postgres clients. Lets instead convert it to a Postgres integer, because that UX problem is probably not worth the space savings to anyone.

Once we do this we can also un-exclude it from this test:

tinyint, -- PG14 outputs this differently currently

@JelteF JelteF added good first issue Good for newcomers types Issues related to type conversions labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers types Issues related to type conversions
Projects
None yet
Development

No branches or pull requests

1 participant