-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask tests could use optimization #56
Comments
Thanks, code looks very promising. Definitely worth to add. Any idea about q10? Even if there is no optimized version for that one, we should still provide valid syntax. We can as well define exception comment that is used to explain the issue, even mentioning gh issue number. |
Im traveling today but may have some time to poke around and make some tweaks. |
Apart from the code itself, I think a big-ish issue with the current setup is that I suspect our default deployment configuration is not ideal for the machine the benchmarks are running on. IIUC the benchmark server is a Looking over the code briefly, I guess the most critical problem right now is that we are not pushing down column projections automatically. This is where https://github.com/dask-contrib/dask-expr should make a big difference. Regarding the missing features, I don't think there is anything missing. I opened #58 to re-enable those missing queries. A follow up PR can go over the existing code and clean that up |
Hi there,
At Coiled we have better optimized versions of the tests
https://github.com/coiled/benchmarks/blob/main/tests/benchmarks/test_h2o.py
Any chance of things being updated to give dask a fairer shot?
The text was updated successfully, but these errors were encountered: