From 8ea60df1000e9119d22a056e1eeb95fa545f07e3 Mon Sep 17 00:00:00 2001 From: Christopher Brind Date: Tue, 11 Feb 2025 16:38:03 +0000 Subject: [PATCH] fixes button movement from home/web to tabswitcher (#3955) Task/Issue URL: https://app.asana.com/0/0/1209358244103060/f Tech Design URL: CC: **Description**: Fix fire button movement by adding some padding to the fire button image. **Steps to test this PR**: 1. Open the tab switcher and make sure the fire button doesn't appear to move. 2. Check on a couple of different phone types. Can ignore SE as that has had a up/down movement problem for some time. **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- .../FireLeftPadded.imageset/Contents.json | 15 +++++++++++++++ .../FireLeftPadded.imageset/fire_2.pdf | Bin 0 -> 4923 bytes .../TabSwitcherViewController+MultiSelect.swift | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/Contents.json create mode 100644 DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/fire_2.pdf diff --git a/DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/Contents.json b/DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/Contents.json new file mode 100644 index 0000000000..56c7fa60a4 --- /dev/null +++ b/DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/Contents.json @@ -0,0 +1,15 @@ +{ + "images" : [ + { + "filename" : "fire_2.pdf", + "idiom" : "universal" + } + ], + "info" : { + "author" : "xcode", + "version" : 1 + }, + "properties" : { + "template-rendering-intent" : "template" + } +} diff --git a/DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/fire_2.pdf b/DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/fire_2.pdf new file mode 100644 index 0000000000000000000000000000000000000000..0b65ad4163208d72a07b9b1de16ff94c8c99d98a GIT binary patch literal 4923 zcmb7Ic|29=|3~|cN|qUo(W%fjj)_SyI-~#C5ZTtLv5}N+e6ADXC;;5MRq= zT2Mow3GFhPjBTcjJ&~m(4f6dQ(|mtT(?7q%i|4$b&;EHo=bY!!v0AfM4@Vh+PH9S6 zZfSa1zCeH@7$R}?LY6NVAc+3vAU`ppZ|ov-@s_yrfR&58*dHN4Xp>;Y3W3( z9{5meT$I<@D0cI7F_Hu#P9TLLgpmJr=4Xs0yL@E`&JQq2K8s2zVd= z^IjCZ!T*cGTVKjmG z2sji22qzI7B}kfMX@o`@0_SKJAyFE`2@XdnRLHSHoIx0rzzB*Z5Rm{T8J1#b1Se3E zWH5$=Ss}qNB!l2Ij0hn`eGC!_J}O6oOYneGD9H#Jj8|n?9H%MB3ng%t##!*nq6GNh zqa{&{CRtX9a41f4LW<)9AxI2knU6stNc3NFV2!~bQr-nE#ic;v7zby=3PS_7*@!mEDH6&iSZFdvKR>?(7`xHDCBhjVjvd^;v$4N1fTR$dM#LW8;{4mbi0VQCg>$h+k` z0d)nGLOBk~1%-nsXq3W8lBWN81M>fvgU&KEgbGceXqJSg@I~i@1VF%G8oCcEBr2q6 zASpBq(k1yyl0aM*vSmjxlJMd25QbqSc;;|| z=KI5<6yyNJVo=~5$?HL&P!56*7*-$%jkg;b&u|=AV@VdG;cLj?LLm-_kOjuWlKU3| zivPkO37V#$A&?A(0crWPSPX}Zf!eTAp|YR{7)wAj99U-{#BnJCD#(`>NJBvLK#1ad z0VZ&sq+pg;r67NX0X{%v7!5S#M>q!^9*>%U;xb_GBN!-u1O<#{367@&G>7E)^#Rmn zSx(547(*#A&GDXblqNZXhD0a=V}v9`4+9cv|G(-&Q!yOs3T1-{975us0W<}S;GlCt zoD*W>Ino%534sOB7Fgrp=iiS>k-$S>w?yCz4^a$?3K!3Y4+s7tUx6Nm=)nRcITmQ- zBOtiizIGh9)9;O0GR%0zi0%ugcrKEetl4znO1wPc=REIXOS$ zmUgVh+L%QB^;YFl*Epxv|0IX1*IQR~yJD&oFNyhePueE6R4aNeY$++44HDjRL(EGK%Z@&uI`sRvDvsV zJ$?Jj!kzsJSJ4eeeZ71hr0kIr@vOrB)RplGcUtp0(ZzSO&9~BWhuq(Op|R7a^Xz=5 zGmcJaC#P)^y5oBP%^;8FpqNjlZt^*Nge1u$1)3+16{KA6+GjAL6xwgNpnv!EQ&Bzl zV#I>@iL#xK?H8|GY_!7AFyU@Fga~`wL25kQsia(=V23Ue^O@^ zn2QQS`?t-SQKO(9J>_oLOky=!rzlvZTsLVje7)6#XR8-@$S+(qg;hes?*Cy>Fs&zS z%C?DzBRaNCE|PyaYog0MV$J^6d0Wh;6JZs|WVe}xt5;YdsxwTCcg~tQ+o-TgJ!|Tc z$R(+cS;~K^8%%NzJ8v|h%FsjgO!(f&CuLL3!?Q0EIZB_EDb`IJJQ&eL`DuPLx#Ood zeHH}@=Od2Zc-}W@$RK2j*8b$Oys4|Arz%++D=JTJ4j-DQZ1zQ|DUC#$ahsy@5oa@f z>2!_N8OH(^DaMAMO;fbKvdD7t)Y!=N#y+dm(w118T0hUys@AJs3vBJO{Z$k)v1iW0j{s#ECR+l_Z~-N+6 zx^=oF;&oYGfBn$x5W|w``zEZ6OI~QEBAdGVz&0ZV7cw=x%BWyXpjn`a_UvC{YRcv2 zpDKv4U%lL-$VgMCWWn992iBqKX2-wIkCz>geJ49Q5NocxBmVQd%5L&O3k#2h92+@3 zVjDi+MY~Do#>u)x);bSSd{MvAZ2fGVPVGWl!Zi2G7wN4^cRd#uow#!1kgAPW#O8$R z#n~>|4xX|3+4;$`T-haA{J@sZbs9N`uN+QNbkhB*{bGelA}%m`m{MS6e?sp>@I9S- zteWw!slnDNStiwztkG%>2aS4hZfdSW?v`A4H&c(P8S8Q#NHtZN=*o z&U#(Aw?)s!F!RsD=!Sr^3m-0hYB-=l=}?wbs^bri*Bgqi#sxi#UtCN@M5T z^AWyhe827SF+8kgtZ&^L_GDwIeWTIJt=HF&9hCRp=J^xFZo@9B7FP!^mUuq?#l`q| zYP`!qm%OGd}lksjGYJieOtD+Sn8_luG4*`JJVcjZg;vpad+ZduMEj8 z;v8|!$AS)E8aU724!okzg#A%C@5}BpA zZ!O*uOEomq2dBOA>n`+NKH4%e34Cv8Pbo1Zl~K5gjL zZBcKw?HsIger#A-TpxO?tW@;v?I6qi%pW^^e|FIq>z}kstE~{6Q|q!D2#ha^C|X*a zJoI$9FZ61NOQTxJo{+ics~zt;)i+HUDH<6ZGJH|nZ~1a;g`CPCbFI|+gjGU}xyVG% zR#mH39nh`g3bcn-NBc%&>B~054j~_xp%qk)(AzDc|NB?x&POdh;9s_E!A0d%WhLdj zbB}F%oei}-l^ter`D@)b)|@%FL#;;l2SXJdjhlxJG>*j0IOH4q_NM_+4el-~a{XSk z-5$*e&FSzq-L0`FR&;xDn|XP|&6Bq*Zq?s>9+MOs5UqbSx&5l&(n5Weo? zKB|psN9tVGZ8@G6Z`tn_7*q6}YQl+}6Z_FSFAN@b7sVocZeV zXDLefXIB|7?}|pYD!EvOFw8iB~8~B3{5Kg z&HKk+y-j^Oe0v*RNq}|5adJ-EnX_kJM-@c%)C5;wsr9T)n0rgJk{!ukkzew9 z$F15UN&+PlrMXA@;tp#nEpK?_@oQaOdiCaC6q)HsnQg1S-F6mVT`mlMHmAk$_OAO~&qLKieOB6!RMkl88~2tyTida*E6I7n{VA0* z3>3E(v;}v)@VW3?ZEsEyiK!B@09G2!OQ&pS?cta`+>ko%{&|f1cum=&v(2 zHgfS7yCM9iD1RdI_opd*2ETU@VGIWkGKmyfPGL01urx)BXgAo^3+e3)LBMXAA?WS! znNAX7*!GA?*z@pb8~RpKiQ6s_e9iv96+HvR-afp~HCF2o*m1poR1+u_Zx>()D}asI zy9=Qyilh*L-(3Wp0r3~&`#%VFEFVBP>{vg5z|{v3&cY7xpHf00Y@I%UC=yPP_zOJB zq%NM`eAeTqTbm>j8NwfUjh_^)^W82%`09?|*?0zvA(8RJ9T%x=JToEewgoymCYEaj F{{{1V1it_P literal 0 HcmV?d00001 diff --git a/DuckDuckGo/TabSwitcherViewController+MultiSelect.swift b/DuckDuckGo/TabSwitcherViewController+MultiSelect.swift index ae428019ca..4bed66d809 100644 --- a/DuckDuckGo/TabSwitcherViewController+MultiSelect.swift +++ b/DuckDuckGo/TabSwitcherViewController+MultiSelect.swift @@ -489,7 +489,7 @@ extension TabSwitcherViewController { self.addNewTab() }) - barsHandler.fireButton.primaryAction = action(image: "Fire") { [weak self] in + barsHandler.fireButton.primaryAction = action(image: "FireLeftPadded") { [weak self] in guard let self else { return } self.burn(sender: self.barsHandler.fireButton) }