Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and possibly update Int columns with new incoming content #47

Closed
duffn opened this issue Feb 22, 2020 · 1 comment
Closed

Review and possibly update Int columns with new incoming content #47

duffn opened this issue Feb 22, 2020 · 1 comment
Labels
data Pertaining to data creation or auditing enhancement New feature or request

Comments

@duffn
Copy link
Owner

duffn commented Feb 22, 2020

New content created by contributors may have values in fields like encumbrance, rarity, damage, etc. that are not Ints. It may be that these do actually need to be strings.

Review and change columns to string types if necessary.

Related to #45.

Examples

From a contributor

I believe the book uses "-" to differentiate from Incidental items ( which would be "0"). I can switch it to 0, but wanted to run that by you first.

@duffn duffn added enhancement New feature or request good first issue Good for newcomers data Pertaining to data creation or auditing labels Feb 22, 2020
@duffn duffn changed the title Review Int columns with new incoming content Review and possibly update Int columns with new incoming content Feb 22, 2020
@duffn duffn removed the good first issue Good for newcomers label Feb 26, 2020
@duffn
Copy link
Owner Author

duffn commented Mar 7, 2020

This is being done as I add data for CotR in #88. After I’m done with that first new book, we should have all of the columns updated appropriately.

@duffn duffn closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Pertaining to data creation or auditing enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant