Duplicate file paths edge-case #2

[jasonkuhrt]

@matthewmueller This is currently impossible to catch:

.a { background-image: url('z.png'); }
.b { background-image: url("../fixtures/z.png"); }

The reason it is impossible to catch is that we don't have any information about the path of the str coming in here: https://github.com/MatthewMueller/file-deps/blob/master/lib/css.js#L33

What I would like to suggest/brain-storm is a minimal API change that would provide the path of given str so that we can rule out dupes more robustly.

[jasonkuhrt]

@matthewmueller Once we sort this out I will update duo but first want to fix this issue. I can provide you with a failing test if that helps clarify the issue here. Let me know... : )

[jasonkuhrt]

Hey I started working on this. A few things I'd like to run by you:

Same:

// @root /
'/b.foo'   // -> /b.foo
'b.foo'    // -> /b.foo
'./b.foo'    // -> /b.foo

Different:

// @root /a/b
'/c.foo'    // -> /c.foo
'c.foo'     // -> /a/c.foo

Error?

// @root /
'../b.foo'   // -> ?

same:

// @root /
'/foo/[email protected]'   // -> /foo/[email protected]
'foo/[email protected]'    // -> /foo/[email protected]
'./foo/[email protected]'  // -> /foo/[email protected]

Two specific questions:

• Do we need to treat local and remote paths differently? If we do, the above example might change to be the following:

  // @root /
  '/foo/[email protected]'   // -> /foo/[email protected]
  'foo/[email protected]'    // DIFFERENT -> foo/[email protected]  
  './foo/[email protected]'  // -> /foo/[email protected]

• Can we return absolute path deps? So instead of this:

  // @root /a/b/c
  ['../bar.js', './foo.js', '/z/y/x/blah.js' ]

  This:

  // @root /a/b/c
  ['/a/b/bar.js', '/a/b/c/foo.js', '/z/y/x/w.js' ]

[dominicbarnes]

For the same reasons as my comment on #12, this change should not be implemented. This normalization should be handled outside of file-deps.

[jasonkuhrt]

Hey. I'm no longer active on these projects so feel free to close etc. Take care!