Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Issues with Mediawiki 1.34 #4

Open
Bigsease30 opened this issue Mar 26, 2020 · 7 comments
Open

Issues with Mediawiki 1.34 #4

Bigsease30 opened this issue Mar 26, 2020 · 7 comments

Comments

@Bigsease30
Copy link

Hello, I would love to start using your Duo product with my Mediawiki. I have followed all of the instructions and have ran across two issues which I will list below.

Issue 1) After successfully entering my credentials, I am prompted with the duoauth login screen. No matter when I change in the Duo-Frame.css, the login is still cut off.
duo-alignment

Issue 2) After selecting the "Send Me a Push" option, I get the notification and approve the login. The wiki screen changes and goes back to the login screen repeating the process.

@AaronAtDuo
Copy link

Re Item 1)
Apparently Chrome no longer likes the height: 500 with no units entry. If I use the dev tools to update that to 500px on the rendered page, the frame looks ok. I am having a similar issue that edits to the CSS file don't get reflected, I wonder if that's some caching issue either in MW or the browser, need to look into that.

Re Item 2)
This looks to be due to the changes in session handling a few releases back. The immediate issue is our use of $_SESSION which is no longer allowed. But even adjusting for that, I'm still not able to retain the state information that the plugin relies on, so it still doesn't work. Need to dig into session and state management in MediaWiki to figure out a plan.

@Bigsease30
Copy link
Author

Perfect. I appreciate you looking in to these issues.

@Bigsease30
Copy link
Author

Hello @AaronAtDuo

I found this and thought that it might assist you and your team for issue 2 above:
https://www.mediawiki.org/wiki/Manual:SessionManager_and_AuthManager/Updating_tips

@AaronAtDuo
Copy link

@Bigsease30 Thanks for the link! Of course, it didn't turn out to be that easy. I tried the suggestion for replacing $_SESSION from that page and there's still problems :(

I'm still poking away at this when I can, so stay tuned.

@AaronAtDuo
Copy link

Update:
Regarding the frame height, the update to the CSS and some cache clearing seems to have resolved that - so is should just be a quick update to the DuoFrame.css file.

The other part of the issue is turning out to be a bigger problem. The session changes are really playing havoc with our approach. I don't see a good way to persist information across the iframe step anymore. This might be a bigger problem than it seems.

@AaronAtDuo
Copy link

As I suspected, the session issues are really causing havoc. At this time, we don't have a clear path forward on how to update the plugin to work to our satisfaction. We're still investigating!

@Bigsease30
Copy link
Author

@AaronAtDuo Thanks for the continued hard work and dedication.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants