Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime environment variables support #80

Open
fuchsberger opened this issue Jan 26, 2023 · 3 comments
Open

runtime environment variables support #80

fuchsberger opened this issue Jan 26, 2023 · 3 comments
Labels

Comments

@fuchsberger
Copy link

Fantastic package, thanks a lot!

Would it be possible to support fetching environment variables at runtime via config/runtime.exs?
Thus replacing Application.get_env/2 with Application.fetch_env/2.

@nelsonic
Copy link
Member

nelsonic commented Jan 26, 2023

Hi Professor @fuchsberger 👋 😉
Thanks for the feedback + feature request! 🙌
Totally. Application.fetch_env/2 makes perfect sense.
You've been invited to the @dwyl org: https://github.com/dwyl
And have write access to this repo: https://github.com/dwyl/elixir-auth-google/invitations

So if you have time to implement with tests/docs please go for it. 👌 (Create a branch and Pull Request)
Otherwise it will stay on our "backlog" until one of the core team can get to it. ⏳

@fuchsberger
Copy link
Author

fuchsberger commented Jan 26, 2023

i would try but its unlikely I get around to it for weeks and might be a little out of my league.
thanks for the feedback!

@nelsonic
Copy link
Member

@fuchsberger fair enough. 👌
It should just be a case statement to check for the presence of the env at runtime. 💭
@SimonLab might be able to look at it next week. ⏳
Thanks again for opening the issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants