From 6261d1c3ca897b61d51b2fb714a9b4f4e9185377 Mon Sep 17 00:00:00 2001 From: Rui <102453770+ruixhuang@users.noreply.github.com> Date: Fri, 26 Jul 2024 13:43:59 -0700 Subject: [PATCH] MOB-615 Fix IntervalText issue when displayed in a list (#207) hiltViewModel() is scoped at the navigation graph, so the same instance is used for the entire screen. Updating it to use "remember" [untitled.webm](https://github.com/user-attachments/assets/6445834c-2e4c-4a47-8292-20286ddcb246) --- .../dydx/trading/feature/shared/views/IntervalText.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v4/feature/shared/src/main/java/exchange/dydx/trading/feature/shared/views/IntervalText.kt b/v4/feature/shared/src/main/java/exchange/dydx/trading/feature/shared/views/IntervalText.kt index eafc9c0c..aa05c457 100644 --- a/v4/feature/shared/src/main/java/exchange/dydx/trading/feature/shared/views/IntervalText.kt +++ b/v4/feature/shared/src/main/java/exchange/dydx/trading/feature/shared/views/IntervalText.kt @@ -4,10 +4,10 @@ import androidx.compose.material.Text import androidx.compose.runtime.Composable import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.collectAsState +import androidx.compose.runtime.remember import androidx.compose.ui.Modifier import androidx.compose.ui.text.TextStyle import androidx.compose.ui.tooling.preview.Preview -import androidx.hilt.navigation.compose.hiltViewModel import androidx.lifecycle.ViewModel import dagger.hilt.android.lifecycle.HiltViewModel import exchange.dydx.platformui.designSystem.theme.dydxDefault @@ -62,7 +62,7 @@ object IntervalText { return } - val viewModel: IntervalTextViewModel = hiltViewModel() + val viewModel = remember { IntervalTextViewModel(formatter = DydxFormatter()) } LaunchedEffect(Unit) { viewModel.start(state.date, state.direction, state.format) }