Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ResourcefulApi #230

Open
eFrane opened this issue Jun 5, 2021 · 1 comment
Open

Split ResourcefulApi #230

eFrane opened this issue Jun 5, 2021 · 1 comment

Comments

@eFrane
Copy link
Owner

eFrane commented Jun 5, 2021

This class tries to do to much. It simultaneously handles the json:api specific request/response wrapping/unwrapping and acts as a container for resource specific actionable route methods.

An idea might be to split the request/response handling into a JsonApi class. Additionally, the route methods handling should be rewritten to be a lot less magical. I don't have a concrete plan for that at the moment though.
@eFrane
Copy link
Owner Author

eFrane commented Jun 5, 2021

Pondering on, most of the request processing done in ResourcefulApi could probably just be pushed up into Api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eFrane