Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyqt as optional dependency #70

Open
ericpre opened this issue Apr 22, 2021 · 5 comments
Open

pyqt as optional dependency #70

ericpre opened this issue Apr 22, 2021 · 5 comments

Comments

@ericpre
Copy link

ericpre commented Apr 22, 2021

qt is a one of the largest dependencies (100 Mo) and can't be used remotely (cloud or cluster). Making this dependency optional would allow to use smaller docker image, etc.

@TomSlater
Copy link
Contributor

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

@ericpre
Copy link
Author

ericpre commented Apr 23, 2021

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

@TomSlater
Copy link
Contributor

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

I'm not sure it is, based on this thread. I could just strip out pyqt as a dependency and include its installation in the standard installation instructions.

@TomSlater
Copy link
Contributor

Maybe it would make most sense to just have pyqt as an optional dependency but use this in the standard instructions.

@ericpre
Copy link
Author

ericpre commented Apr 23, 2021

Yes, this is usually how it is done.

On a similar topic, it may be worth considering using qtpy, to allow using pyside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants