Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for the feedback module #293

Open
lwasser opened this issue Sep 26, 2020 · 3 comments
Open

Write tests for the feedback module #293

lwasser opened this issue Sep 26, 2020 · 3 comments
Assignees
Labels

Comments

@lwasser
Copy link

lwasser commented Sep 26, 2020

this module is currently completely untested.
i think to do this well we will want to create some fixtures that setup the dir structure that we wish to use throughout the tests.

@lwasser
Copy link
Author

lwasser commented Sep 30, 2020

hi @nkorinek this is the issue that you will work on for the feedback module! please know that i've merged all of the open pr's that relate to that module so you can integrate updates from master into your pr! Please let me know if you run into issues. i KNOW there are many bugs that you will find with writing tests!! so let's just deal with those using issues as they come up.

get in touch with any questions

You can focus on tests that do not involve github for the time being (we can worry about monkey patching later!). let's just make sure that the core functionality works first!

@lwasser
Copy link
Author

lwasser commented Jan 27, 2022

@kcranston has a part of this done already ... so we will look for this work and potentially merge some of it.

@lwasser
Copy link
Author

lwasser commented Jan 27, 2022

NOTE there are two pull requests open here related to this issue
#296 #307 @kcranston @nkorinek i can't remember why we had two pr's opened within a month of each other. so perhaps we can consolidate those PR's and merge any things that are "final" in them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants